Skip to content

Conversation

@N6REJ
Copy link
Contributor

@N6REJ N6REJ commented Aug 15, 2025

PR Type

Enhancement


Description

  • Add Bruno 2.9.1 version configuration

  • Update bundle release date to 2025.8.15

  • Add new release entry for version 2.9.1


Diagram Walkthrough

flowchart LR
  A["New Bruno 2.9.1"] --> B["Configuration File"]
  A --> C["Build Properties"]
  A --> D["Release Registry"]
  B --> E["bruno.exe executable"]
  C --> F["Updated release date"]
  D --> G["Download URL mapping"]
Loading

File Walkthrough

Relevant files
Configuration changes
bearsampp.conf
Add Bruno 2.9.1 configuration file                                             

bin/bruno2.9.1/bearsampp.conf

  • Create new configuration file for Bruno 2.9.1
  • Set version identifier and executable name
+2/-0     
build.properties
Update bundle release date                                                             

build.properties

  • Update bundle release date from 2025.8.8 to 2025.8.15
  • Add formatting with blank lines
+3/-1     
releases.properties
Register Bruno 2.9.1 release                                                         

releases.properties

  • Add new release entry for Bruno 2.9.1
  • Map version to download URL with 2025.8.15 date
+1/-0     

@N6REJ N6REJ added the bug Something isn't working label Aug 15, 2025
@qodo-merge-pro
Copy link
Contributor

qodo-merge-pro bot commented Aug 15, 2025

PR Reviewer Guide 🔍

(Review updated until commit 5b01380)

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Consistency

Verify that the new brunoVersion and brunoExe keys match expected naming and schema across existing versions to avoid loader/parsing issues, and ensure the path/version folder bruno2.9.1 aligns with tooling that discovers configs.

brunoVersion = "2.9.1"
brunoExe = "bruno.exe"
URL Accuracy

Confirm the 2.9.1 download URL and date stamp resolve correctly and follow the established naming pattern; a mismatch here will break automated downloads.

2.9.1 = https://github.com/Bearsampp/module-bruno/releases/download/2025.8.15/bearsampp-bruno-2.9.1-2025.8.15.7z
Release Date Sync

Ensure bundle.release = 2025.8.15 is in sync with the new release entry and any CI/CD logic that derives artifact names from this date.

bundle.release = 2025.8.15

@qodo-merge-pro
Copy link
Contributor

qodo-merge-pro bot commented Aug 15, 2025

PR Code Suggestions ✨

Latest suggestions up to 5b01380

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
General
Remove unnecessary quotes in config

Drop the surrounding quotes to match typical key=value semantics used by other
module configs and avoid accidental inclusion of quotes in parsed values. Ensure
values are plain strings unless the parser explicitly requires quoting.

bin/bruno2.9.1/bearsampp.conf [1-2]

-brunoVersion = "2.9.1"
-brunoExe = "bruno.exe"
+brunoVersion = 2.9.1
+brunoExe = bruno.exe
  • Apply / Chat
Suggestion importance[1-10]: 5

__

Why: This suggestion correctly points out that removing quotes for simple values in config files is good practice, which enhances robustness by preventing potential parsing issues.

Low
Remove extraneous blank lines

Remove unnecessary blank lines to avoid misparsing by strict properties parsers
and to keep formatting consistent with the rest of the file. Properties files
typically use comments or contiguous key-value pairs without extra separators.

build.properties [1-6]

 bundle.name = bruno
-
 bundle.release = 2025.8.15
-
 bundle.type = tools
 bundle.format = 7z
  • Apply / Chat
Suggestion importance[1-10]: 3

__

Why: This is a minor stylistic suggestion that reverts the addition of blank lines, aligning with the file's previous format and potentially improving compatibility with strict parsers.

Low
  • More

Previous suggestions

✅ Suggestions up to commit f0fefcc
CategorySuggestion                                                                                                                                    Impact
Possible issue
Validate release URL pattern
Suggestion Impact:The commit includes the 2.9.1 URL with matching version and date as suggested, effectively implementing the validation by adding the correct entry; it also added 2.9.0 similarly.

code diff:

+2.9.0 = https://github.com/Bearsampp/module-bruno/releases/download/2025.8.8/bearsampp-bruno-2.9.0-2025.8.8.7z
 2.9.1 = https://github.com/Bearsampp/module-bruno/releases/download/2025.8.15/bearsampp-bruno-2.9.1-2025.8.15.7z

URL components must exactly match the tag and artifact naming conventions;
ensure the tag path and filename both include the same version and date. If your
release tag uses a different pattern (e.g., v2.9.1), adjust the URL accordingly
to prevent 404s.

releases.properties [14]

+2.9.1 = https://github.com/Bearsampp/module-bruno/releases/download/2025.8.15/bearsampp-bruno-2.9.1-2025.8.15.7z
 
-

[Suggestion processed]

Suggestion importance[1-10]: 7

__

Why: This is a valuable suggestion as it prompts the user to verify the newly added release URL, which is critical for functionality, and an incorrect URL would lead to a broken download link.

Medium
General
Remove unnecessary quotes

Remove the surrounding quotes to keep consistency with typical key=value config
parsing, which may treat quoted values literally. This avoids downstream scripts
reading the quotes as part of the value.

bin/bruno2.9.1/bearsampp.conf [1-2]

-brunoVersion = "2.9.1"
-brunoExe = "bruno.exe"
+brunoVersion = 2.9.1
+brunoExe = bruno.exe
Suggestion importance[1-10]: 4

__

Why: The suggestion offers a reasonable style improvement by removing quotes, which can enhance consistency and prevent potential parsing issues depending on the configuration file parser.

Low
✅ Suggestions up to commit d24c257
CategorySuggestion                                                                                                                                    Impact
Possible issue
Align config version with release
Suggestion Impact:The commit updated brunoVersion from "2.8.1" to "2.9.1" exactly as suggested.

code diff:

-brunoVersion = "2.8.1"
+brunoVersion = "2.9.1"

Update the brunoVersion to match the new 2.9.1 release to avoid version mismatch
issues. Ensure the config aligns with the corresponding release entry and
directory name.

bin/bruno2.9.1/bearsampp.conf [1-2]

-brunoVersion = "2.8.1"
+brunoVersion = "2.9.1"
 brunoExe = "bruno.exe"

[Suggestion processed]

Suggestion importance[1-10]: 9

__

Why: The suggestion correctly identifies a critical version mismatch where the new config file bin/bruno2.9.1/bearsampp.conf has brunoVersion set to "2.8.1" instead of "2.9.1", which could cause runtime errors.

High
General
Ensure release URL consistency
Suggestion Impact:The committed change adds version 2.9.0 with a URL matching the established naming pattern and keeps versions in sorted order, aligning with the suggestion’s intent to ensure consistency and sorting.

code diff:

+2.9.0 = https://github.com/Bearsampp/module-bruno/releases/download/2025.8.8/bearsampp-bruno-2.9.0-2025.8.8.7z
 2.9.1 = https://github.com/Bearsampp/module-bruno/releases/download/2025.8.15/bearsampp-bruno-2.9.1-2025.8.15.7z

Verify the new URL follows the exact naming convention used by previous
releases, including date and artifact pattern. If tooling parses in order, keep
entries sorted by version to prevent unexpected selection behavior.

releases.properties [13-14]

+2.8.1 = https://github.com/Bearsampp/module-bruno/releases/download/2025.7.31/bearsampp-bruno-2.8.1-2025.7.31.7z
+2.9.1 = https://github.com/Bearsampp/module-bruno/releases/download/2025.8.15/bearsampp-bruno-2.9.1-2025.8.15.7z
 
-

[Suggestion processed]

Suggestion importance[1-10]: 4

__

Why: The suggestion asks to verify URL naming conventions and version sorting, which are good practices, but the code in the PR already follows these conventions correctly, making the suggestion a minor verification prompt.

Low

Co-authored-by: qodo-merge-pro[bot] <151058649+qodo-merge-pro[bot]@users.noreply.github.com>
@jwaisner jwaisner merged commit aa951fe into main Aug 15, 2025
@jwaisner jwaisner deleted the 2.9.1 branch August 15, 2025 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Review effort 1/5

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants