-
Notifications
You must be signed in to change notification settings - Fork 97
using string-suffix-array-functionality branch instead of master #627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
zhihuidu
wants to merge
63
commits into
Bears-R-Us:master
from
zhihuidu:string-suffix-array-functionality
Closed
Changes from all commits
Commits
Show all changes
63 commits
Select commit
Hold shift + click to select a range
65ad500
add the suffix array function to Arkouda
zhihuidu 7af0b51
add suffix array benchmark sa.py
zhihuidu d288c10
add read file suffix array function and all libdivsufsort files
zhihuidu 9a22704
change name
zhihuidu c81d755
add suffix_array Python test
zhihuidu dbd6d96
add Chapel skew suffix array algorithm
zhihuidu 21df359
add the lcp array method
zhihuidu 940cb79
confirm submit all changes
zhihuidu 9f22f79
add thirdpary files
zhihuidu 3a220dc
solve conflict
zhihuidu 4131820
add thirdparty files
zhihuidu c9e03fb
updated
dbader13 d184048
Update SACA.chpl comments
alvaradoo 8f88f4c
Merge pull request #3 from alvaradoo/patch-1
zhihuidu b6228e5
remove tab, remove unused codes
zhihuidu 42e3ba7
change to relative directory
zhihuidu 9702d46
include sa.py into run_benchmarks.py
zhihuidu 7a0b197
suffix_arry_file updated
zhihuidu e90ca27
remove tab in MultiTypeSymEntry.chpl
zhihuidu 2db17d8
datatype in string.py
zhihuidu da30cfa
remove suffixarray_test.py
zhihuidu 6b6e41a
update third party config
zhihuidu 38818a3
follow suggestions from community
zhihuidu 32ecc0c
solve the conflict
zhihuidu a6c536e
update the SegSArray
zhihuidu 16cca77
remove unused import
zhihuidu 9d60563
align with strings function
zhihuidu 59174ac
correct a typo
zhihuidu 0cda91d
type match
zhihuidu e1c3173
data type
zhihuidu 3861e62
bool or pdarray
zhihuidu edc3f63
remove binary op
zhihuidu 6074b60
remove binary op
zhihuidu 4f773e2
remove the bug causing wrong return string value
zhihuidu 267238c
import SArrays class in pdarraysetops.py
zhihuidu 189c32e
add an empty correctness function
zhihuidu 0aa835c
copy master gather.py
zhihuidu ed98498
make sa.py check easy
zhihuidu 9f5c3d3
check test/*.chpl
zhihuidu ac7e209
add corectness check in sa.py
zhihuidu 6fd3b05
change suffix array return as an int array
zhihuidu 50be2e3
copy string_test.py
zhihuidu f1781e8
Fixed bug in UnitTestPeelStick
reuster986 221679e
update lcp related code
zhihuidu a8a195a
Merge pull request #4 from reuster986/master
zhihuidu 0bff3e4
remove the enhenced attribute in sym table
zhihuidu 2af5ce8
check the comments to remove docs CI check error
zhihuidu 2d40c0e
solve the sphinx error
zhihuidu c782b5a
add switch betwteen different SA algorithms
zhihuidu 00b3579
single locales for C code
zhihuidu 80f78c6
resolve convlict
zhihuidu 010a446
return the string for suffix_array_file
zhihuidu f5ca67a
remove mypy CI check error
zhihuidu 6d65335
tuple data type
zhihuidu fb89d88
solve conflict of suffix array, SegmentedMsg, SegmentedArray and run…
zhihuidu 18f481c
handle some bytes to string
zhihuidu 924ac94
Merge branch 'master' of github.com:mhmerrill/arkouda
zhihuidu 87c6327
merge with the latest version
zhihuidu 82776f9
solve the inconsistency in dtype
zhihuidu dda2264
Merge branch 'master' into string-suffix-array-functionality
stress-tess a543312
Minimum changes to pass current tests (1/2):
6f8cbfe
Minimum changes to pass current tests (2/2):
a9167e6
Merge branch 'master' into pr/627
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While not the biggest deal, there are a handful of place where spacing/formatting differs from the rest of the arkouda codebase. This is a bit of nitpick but I think having consistency is important for readability/maintainability
I would likely update this representative example to look something like this