-
Notifications
You must be signed in to change notification settings - Fork 97
Closes #5096: unit tests for inherited functions in arkouda extension array #5102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Closes #5096: unit tests for inherited functions in arkouda extension array #5102
Conversation
ad25375 to
8e6e666
Compare
1520945 to
ff72e6b
Compare
1RyanK
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
982b02e to
a5db5b0
Compare
67a7ece to
e2280c7
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5102 +/- ##
========================================
Coverage ? 100.00%
========================================
Files ? 5
Lines ? 109
Branches ? 0
========================================
Hits ? 109
Misses ? 0
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
5dc52fc to
82786a5
Compare
… extension array
82786a5 to
0b0c8f0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The number of tests marked xfails feels surprising. I assume this is deliberate?
PR: Comprehensive Pandas ExtensionArray Inheritance Tests + Categorical Stubs
Summary
This PR introduces a comprehensive test suite verifying that Arkouda’s
ArkoudaArray,ArkoudaStringArray, andArkoudaCategoricalArraycorrectly inherit behavior frompandas.api.extensions.ExtensionArray.Tests ensure:
1. Arkouda Does Not Override pandas EA Methods
For each method, the suite asserts:
Verified inherited methods include:
_fill_mask_inplace,_formatter,_from_scalars,_get_repr_footer,_hash_pandas_object,_putmask,_rank,_repr_2d,_values_for_argsort,delete,dropna,insert,isin,map,ravel,repeat,searchsorted,shift,tolist,transpose,unique, and more.2. Behavior-Level Parity With pandas
Tests check:
3. Known Unsupported Behavior Is Explicitly Tested
Some pandas behaviors require dtype conversions Arkouda does not support yet.
Locked-in expected behaviors:
ArkoudaCategoricalArray.map→ xfailArkoudaCategoricalArray.shift→ raisesNotImplementedError_repr_2don numeric EAs → raisesTypeError4. Added
NotImplementedErrorStubs for Categorical InternalsStubs added for pandas Categorical-internal helper APIs:
_set_categories,_replace,_reverse_indexer,_values_for_rank,add_categories,rename_categories,remove_unused_categories, etc.5. Test Coverage Improvements
Covers:
Motivation
Previously:
This PR establishes a correctness baseline.
Examples
Test Commands
Closes #5096: unit tests for inherited functions in arkouda extension array