Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes 3813 and 3866 -- moves several new functions to the new interface (abs, square, all exp and log, isnan, isinf, isfinite) #3873

Conversation

drculhane
Copy link
Contributor

Closes #3813 and #3866

@drculhane
Copy link
Contributor Author

Also adds tests for square, isinf and isfinite to tests/numpy/numeric_test.py

@drculhane drculhane linked an issue Oct 25, 2024 that may be closed by this pull request
@drculhane drculhane marked this pull request as ready for review October 25, 2024 17:29
Copy link
Contributor

@ajpotts ajpotts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

src/EfuncMsg.chpl Outdated Show resolved Hide resolved
src/EfuncMsg.chpl Outdated Show resolved Hide resolved
src/EfuncMsg.chpl Outdated Show resolved Hide resolved
tests/numpy/numeric_test.py Show resolved Hide resolved
@drculhane drculhane force-pushed the Closes-3813-3866-moves-abs-sq-exp-log-is-fns-to-new-interface branch from 605542c to d60bd85 Compare November 1, 2024 15:28
Copy link
Member

@stress-tess stress-tess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nothing popped at me other than the 3 dim registration-config comment

registration-config.json Outdated Show resolved Hide resolved
@ajpotts ajpotts added this pull request to the merge queue Nov 14, 2024
Merged via the queue into Bears-R-Us:master with commit 2fe82af Nov 14, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants