Skip to content

Conversation

@stress-tess
Copy link
Member

@stress-tess stress-tess commented Mar 3, 2022

My first pass at bringing the suffix array functionality into arkouda-njit

I have successfully compiled with this functionality using $ python server-config.py --arkouda=$HOME/proj/arkouda | bash. But haven't figured out a way to test the suffix-array functionality yet. I'm putting this up to get some preliminary thoughts.

Major changes other than relocating functions are:

  • Renaming SegmentedMsg to SuffixArrayMsg to avoid conflicting with main repo and renaming the functions within to include Int (following the example of other functions in suffix array). The strings functionality was removed from these functions
  • Updates to locations where .lookup was called. This has been replaced with getGenericTypedArrayEntry
  • Updates to locations referencing segstrings as 2 parts (bytes and values) instead of one composite entry
  • The siphash code from the original PR is not included because I think SipHash is able to handle it. I might be wrong about that and need to figure out a way to add that in

This functionality is being transferred from PR #865 in the main arkouda repo
and tracked in Issue #1173 in the main repo

@zhihuidu
Copy link
Contributor

zhihuidu commented Mar 4, 2022

@glitch Now based on your framework we can compile the arkouda_server successfully. I saw Pierce had the unit test code on suffix array. So, I wonder how we should organize the unit test code, the python test code so we can "make test-all" as before (we need to copy the chapel and python test codes to the corresponding arkouda directories) or "make test-all" will just test our local chapel and python testing code?

@zhihuidu zhihuidu merged commit ce1c119 into Bears-R-Us:main Mar 7, 2022
mdindoost pushed a commit that referenced this pull request Jul 20, 2024
First pass at suffix_arrays in arkouda-njit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants