Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring velocity predictors #127

Open
wants to merge 18 commits into
base: staging-collab-2
Choose a base branch
from

Conversation

PalkaPuri
Copy link
Contributor

@PalkaPuri PalkaPuri commented Sep 25, 2024

Updated formulation of Vicsek predictors to remove vector averaging of velocity magnitude. The velocity magnitude is now sampled from a gaussian centered at the velocity of previous time step. Previously used _generic_velocity_predictor with a mechanism-specific transformation of interaction partner velocities did not allow for this change in the vicsek predictor. So I have now removed it, and I directly wrote two generate functions for pairwiseCopying and vicsek.

@PalkaPuri PalkaPuri added status:WIP Work-in-progress not yet ready for review collab2.0 labels Sep 25, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@PalkaPuri PalkaPuri changed the base branch from main to staging-collab-2 September 25, 2024 22:23
@rfl-urbaniak
Copy link
Collaborator

We updated staging-collab-2, please make sure you pull origin, resolve conflicts and pass the tests.

@PalkaPuri
Copy link
Contributor Author

PalkaPuri commented Oct 7, 2024

I updated velocity_predictors.ipynb to test both pairwiseCopying and vicsek predictors, removed vicsek_predictor.ipynb. Also pruned the notebook to only use the non-underscored (exposed) generate functions. Found a bug in animate_predictors that did not allow plotting positions of a selected set of foragers. Fixed that in this PR as well.

@PalkaPuri
Copy link
Contributor Author

I deleted compute_velocity.ipynb which tests _add_velocity function since (1) we want to avoid importing underscored functions (2) _add_velocity is implicitly tested when generate_pairwiseCopying_predictor and generate_vicsek_predictor are called in velocity_predictors.ipynb

@PalkaPuri PalkaPuri changed the base branch from staging-collab-2 to pp-add-velocity-bug October 7, 2024 09:47
@PalkaPuri PalkaPuri added status:awaiting review Awaiting response from reviewer and removed status:WIP Work-in-progress not yet ready for review labels Oct 7, 2024
@PalkaPuri PalkaPuri changed the base branch from pp-add-velocity-bug to staging-collab-2 October 7, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:awaiting review Awaiting response from reviewer velocity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants