test(replication): make sequence handshake tests deterministic - #900
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sequence handshake tests queued warmup entries through the asynchronous sender. Entries still pending when the reader connected could advance its sequence before the assertion, making unrelated PRs fail CI. This reproduced on the unchanged base of #898: the test expected 100 and observed 899 during 500 runs with the race detector and two CPUs.
Seed the test sender's sequence directly so the handshake assertions run without pending traffic. The restart test still sends a real entry after activation and verifies delivery. Production behavior is unchanged.
Refs #898 and #887.
Validation:
-tags=duckdb_arrow -race -cpu=2.-tags=duckdb_arrow -race.go vet -tags=duckdb_arrow ./internal/cluster/replicationpassed.git diff --checkpassed.AI assistance: Codex assisted with diagnosis, implementation, and validation.