fix(iceberg,backup): complete #639 items 2, 5, 7, 8 - #693
Merged
Merged
Conversation
Item 2: once-per-process WARN when the reconciler is gated off on a node, naming the no-compactor-role failure mode. Item 5: warehouseRelKey resolves symlinks symmetrically (cached constant sides, dir fallback for not-yet-written locations, remote schemes untouched). Item 7: after each commit, tighten local warehouse metadata written by iceberg-go to owner-only bits; tighten-only, restrictive modes stay. Item 8: restore staging streams via ReadTo instead of double-buffering the database. Refs #639
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part 1 of finishing the #639 audit sweep (item 3, catalog cleanup on database drop, follows separately as the one destructive-path change):
warehouseRelKeyresolves symlinks before comparing, symmetrically across the metadata location, warehouse, and storage root (constant sides cached; parent-dir fallback for not-yet-written locations; s3/azure schemes bypass untouched), so a symlinked storage root no longer lands every commit in warn-once hint-unaddressable modeReadToinstead of buffering multi-GB databases in memory twiceProcess
Batched adversarial plan review before implementation (which set the tighten-only requirement's groundwork, the symmetric-resolution shape, and confirmed the chmod walk is bounded by the retain cap); unit tests per item.
Verification
Refs #639