Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test values #90

Merged
merged 17 commits into from
Jul 11, 2024
Merged

Update test values #90

merged 17 commits into from
Jul 11, 2024

Conversation

kevin-pease
Copy link
Contributor

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

  • Updates several test values which have changed after the recent Testnet reset;
  • Removes several 'unused import' and 'unused variable' warnings;
  • Fixes 2 code examples in the documentation.

Additionally, due to the new response data, it became clear that some values in some response models are optional. This was not specified in the Stellar documentation. The affected struct fields have been modified using Option<>.

🤔 Checklist before submitting

  • All projects build
  • Follows style guide lines
  • Relevant documentation was updated
  • Rebased onto current main

@LeonardTibben LeonardTibben self-requested a review July 11, 2024 07:08
@LeonardTibben LeonardTibben merged commit 5b26ded into develop Jul 11, 2024
2 checks passed
@kevin-pease kevin-pease deleted the test-fixes branch July 11, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants