Order book #47
Merged
Order book #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tluijken
previously requested changes
Apr 5, 2024
There was a problem hiding this comment.
Dat heb je mooi gedaan!
Enige kanttekening die ik heb: er zijn een aantal waarden waarbij de naam niet veelzeggend is. Die komen ook zo terug uit de API. Maar welicht kunnen we consumers van deze SDK wel op weg helpen door iets meer toelichting te geven wat deze velden betekenen, e/o een zinvollere naamgeving geven.
Dat is het kleine beetje extra effort wat een SDK heel waardevol maakt voor een developer.
Verder: Top!!
kevin-pease
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
order book details endpoint