Operations #46
Merged
Operations #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeonardTibben
force-pushed
the
operations
branch
from
4f2c5e6
to
b931d9d
Compare
tluijken
requested changes
Mar 26, 2024
Comment on lines
100
to
117
| let mut query = String::new(); | ||
| if let Some(account_id) = &self.account_id { | ||
| query.push_str(&format!("accounts/{}&", account_id)); | ||
| } | ||
| if let Some(cursor) = self.cursor { | ||
| query.push_str(&format!("cursor={}&", cursor)); | ||
| } | ||
| if let Some(limit) = self.limit { | ||
| query.push_str(&format!("limit={}&", limit)); | ||
| } | ||
| if let Some(order) = &self.order { | ||
| query.push_str(&format!("order={:?}&", order)); | ||
| } | ||
| if let Some(include_failed) = &self.include_failed { | ||
| query.push_str(&format!("include_failed={:?}&", include_failed)); | ||
| } | ||
|
|
||
| query.trim_end_matches('&').to_string() |
There was a problem hiding this comment.
Suggested change
| let mut query = String::new(); | |
| if let Some(account_id) = &self.account_id { | |
| query.push_str(&format!("accounts/{}&", account_id)); | |
| } | |
| if let Some(cursor) = self.cursor { | |
| query.push_str(&format!("cursor={}&", cursor)); | |
| } | |
| if let Some(limit) = self.limit { | |
| query.push_str(&format!("limit={}&", limit)); | |
| } | |
| if let Some(order) = &self.order { | |
| query.push_str(&format!("order={:?}&", order)); | |
| } | |
| if let Some(include_failed) = &self.include_failed { | |
| query.push_str(&format!("include_failed={:?}&", include_failed)); | |
| } | |
| query.trim_end_matches('&').to_string() | |
| vec![ | |
| self.cursor.as_ref().map(|c| format!("cursor={}", c)), | |
| self.limit.as_ref().map(|l| format!("limit={}", l)), | |
| self.order.as_ref().map(|o| format!("order={}", o)), | |
| self.include_failed.as_ref().map(|i| format!("include_failed={}", i)), | |
| ] | |
| .build_query_parameters() |
Comment on lines
100
to
116
| let mut query = String::new(); | ||
| if let Some(ledger_sequence) = &self.ledger_sequence { | ||
| query.push_str(&format!("&ledger_sequence={}", ledger_sequence)); | ||
| } | ||
| if let Some(cursor) = &self.cursor { | ||
| query.push_str(&format!("&cursor={}", cursor)); | ||
| } | ||
| if let Some(limit) = &self.limit { | ||
| query.push_str(&format!("&limit={}", limit)); | ||
| } | ||
| if let Some(order) = &self.order { | ||
| query.push_str(&format!("&order={}", order)); | ||
| } | ||
| if let Some(include_failed) = &self.include_failed { | ||
| query.push_str(&format!("&include_failed={}", include_failed)); | ||
| } | ||
| query |
There was a problem hiding this comment.
Suggested change
| let mut query = String::new(); | |
| if let Some(ledger_sequence) = &self.ledger_sequence { | |
| query.push_str(&format!("&ledger_sequence={}", ledger_sequence)); | |
| } | |
| if let Some(cursor) = &self.cursor { | |
| query.push_str(&format!("&cursor={}", cursor)); | |
| } | |
| if let Some(limit) = &self.limit { | |
| query.push_str(&format!("&limit={}", limit)); | |
| } | |
| if let Some(order) = &self.order { | |
| query.push_str(&format!("&order={}", order)); | |
| } | |
| if let Some(include_failed) = &self.include_failed { | |
| query.push_str(&format!("&include_failed={}", include_failed)); | |
| } | |
| query | |
| vec![ | |
| self.cursor.as_ref().map(|c| format!("cursor={}", c)), | |
| self.limit.as_ref().map(|l| format!("limit={}", l)), | |
| self.order.as_ref().map(|o| format!("order={}", o)), | |
| self.include_failed.as_ref().map(|i| format!("include_failed={}", i)), | |
| ] | |
| .build_query_parameters() |
Comment on lines
13
to
71
| impl SingleOperationRequest<NoOperationId> { | ||
| pub fn new() -> Self { | ||
| SingleOperationRequest::default() | ||
| } | ||
|
|
||
| pub fn set_operation_id(self, operation_id: String) -> SingleOperationRequest<OperationId> { | ||
| SingleOperationRequest { | ||
| operation_id: OperationId(operation_id), | ||
| } | ||
| } | ||
| } | ||
|
|
||
| impl Request for SingleOperationRequest<OperationId> { | ||
| fn get_query_parameters(&self) -> String { | ||
| let mut query = String::new(); | ||
| query.push_str(&format!("{}", self.operation_id.0)); | ||
|
|
||
| query.trim_end_matches('&').to_string() | ||
| } | ||
|
|
||
| fn build_url(&self, base_url: &str) -> String { | ||
| format!( | ||
| "{}/{}/{}", | ||
| base_url, | ||
| super::OPERATIONS_PATH, | ||
| self.get_query_parameters() | ||
| ) | ||
| } | ||
| } |
There was a problem hiding this comment.
Hier mag van mij nog wel iets documentatie bij.
response struct operations per account request added documentation fee stats refactor Updated percentage new files response struct operations per account request added documentation duplicate fix lib.rs documenation small fix added operations for ledgers test simgle operation request documentation
LeonardTibben
force-pushed
the
operations
branch
from
dc18656
to
f6af29b
Compare
tluijken
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
endpoints for
I was planning on doing every operation enpoint but the pr is already getting too big.
There is also some code formatting in this pr which increases the amount of files changed a lot but is otherwise uninteresting.