Add effects-for-ledger endpoint #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejorritsma
force-pushed
the
effects-endpoint-for-ledger
branch
from
294315d
to
212a656
Compare
ejorritsma
force-pushed
the
effects-endpoint-for-ledger
branch
from
212a656
to
d45ef22
Compare
ejorritsma
force-pushed
the
effects-endpoint-for-ledger
branch
from
d45ef22
to
5ce4d29
Compare
LeonardTibben
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
🐛 Recommendations for testing
Tests the endpoint by adding a ledger sequence to make sure the URL is built right.
Please note that the ledger sequence is part of the URL when added, instead of being part of the query parameters.
📝 Links to relevant issues/docs
Please note that the documentation at this time is incomplete.
This is by design, because the way things are implemented is continuously changing as we implement this family of endpoints. By the end, all documentation will be updated.