Implement Typestate Builder Pattern #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tluijken
requested changes
Nov 24, 2023
ejorritsma
changed the title
This was referenced Nov 28, 2023
ejorritsma
force-pushed
the
10-request-validation-at-compile-time
branch
from
84a4ee4
to
e2a1944
Compare
tluijken
force-pushed
the
10-request-validation-at-compile-time
branch
from
d73232c
to
ff850f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
A rewrite of the way request building works. This introduces the advantage of validation of requests at compile time.
Currently, requests are validated at runtime, which may lead to unexpected behavior.
🆕 What is the new behavior (if this is a feature change)?
Now, requests are validated at compile time.
💥 Does this PR introduce a breaking change?
Yes. However, since we are not running in production yet, I think we will be ok.
🐛 Recommendations for testing
Run the tests, which have been unchanged.
📝 Links to relevant issues/docs
#10
🤔 Checklist before submitting