Skip to content
This repository was archived by the owner on Oct 5, 2021. It is now read-only.

Correct the Android compileSdk version documentation #20

Merged
merged 1 commit into from
Oct 19, 2019

Conversation

mvanbeusekom
Copy link
Member

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

Docs

⤵️ What is the current behavior?

Currently the README.md describes that the user should set the "compileSDK" value to 28, but in the example it is set to 29. This confuses users.

🆕 What is the new behavior (if this is a feature change)?

Corrected the documentation and the example. The documentation now mentions the user should use a "compileSDK" of 28 or higher and in the example code the value is set to 28.

💥 Does this PR introduce a breaking change?

No

🐛 Recommendations for testing

Only documentation

📝 Links to relevant issues/docs

🤔 Checklist before submitting

  • All projects build
  • Follows style guide lines (code style guide)
  • Relevant documentation was updated
  • Rebased onto current develop

@mvanbeusekom mvanbeusekom merged commit 220f9ad into develop Oct 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mismatch in compileSdkVersion in Readme.
1 participant