Skip to content

Make DefaultMediaSourceFactory implements IMediaSourceFactory (Xamarin branch) #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jonathanantoine
Copy link

@jonathanantoine jonathanantoine commented Jan 10, 2024

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

Make DefaultMediaSourceFactory implements IMediaSourceFactory

⤵️ What is the current behavior?

Its missing this interface

🆕 What is the new behavior (if this is a feature change)?

I add this interface and let us customize the player by using it like this :

DefaultExtractorsFactory extractorsFactory =
    new DefaultExtractorsFactory()
        .SetMp3ExtractorFlags(Mp3Extractor.FlagEnableConstantBitrateSeeking);
var mediaSourceFactory = new DefaultMediaSourceFactory(Application.Context, extractorsFactory);
player = exoPlayerBuilder
    .SetMediaSourceFactory(mediaSourceFactory)
    ?.Build();

💥 Does this PR introduce a breaking change?

No

🐛 Recommendations for testing

📝 Links to relevant issues/docs

#150 : MonoAndroid bindings issues: IMediaSourceFactory and DownloadService

🤔 Checklist before submitting

  • [x ] All projects build
  • [x ] Follows style guide lines
  • [ x] Relevant documentation was updated
  • [x ] Rebased onto current xamarin

@jonathanantoine jonathanantoine changed the title Make DefaultMediaSourceFactory implements IMediaSourceFactory Make DefaultMediaSourceFactory implements IMediaSourceFactory (Xamarin branch) Jan 10, 2024
@martijn00 martijn00 merged commit 7354e29 into Baseflow:xamarin Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants