Skip to content

move name email to right side in desktop settings#4564

Open
krushnarout wants to merge 2 commits intomainfrom
setting-ui-change
Open

move name email to right side in desktop settings#4564
krushnarout wants to merge 2 commits intomainfrom
setting-ui-change

Conversation

@krushnarout
Copy link
Member

before:

Image

after:

Screenshot 2026-02-02 at 7 11 04 PM

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the settings pages to move item values like name, email, and language to the right side of the tile, which improves the layout and alignment with the new design. The changes are implemented by introducing a value property in OmiSettingsTile and _buildSettingsRow widgets. The implementation is mostly correct, but I've found a layout bug in OmiSettingsTile where spacing is missing when both a value and a trailing widget are provided. My review includes a suggestion to fix this and simplify the layout logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant