move name email to right side in desktop settings#4564
Open
krushnarout wants to merge 2 commits intomainfrom
Open
move name email to right side in desktop settings#4564krushnarout wants to merge 2 commits intomainfrom
krushnarout wants to merge 2 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the settings pages to move item values like name, email, and language to the right side of the tile, which improves the layout and alignment with the new design. The changes are implemented by introducing a value property in OmiSettingsTile and _buildSettingsRow widgets. The implementation is mostly correct, but I've found a layout bug in OmiSettingsTile where spacing is missing when both a value and a trailing widget are provided. My review includes a suggestion to fix this and simplify the layout logic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
before:
after: