BackgroundService.stopRecorder - LateInitializationError crash

[aaravgarg]

Summary

• Guard stopRecorder() and stop() methods with _status check before accessing _service
• Prevents LateInitializationError when these methods are called before init() completes
• Returns early with a debug log instead of crashing

Crash Stats

• Events: 16
• Users affected: 14
• Crashlytics: View in Console

Test plan

• Verify recorder start/stop still works after initialization
• Test calling stopRecorder before init (should log warning, not crash)

🤖 Generated with Claude Code

[gemini-code-assist]

Code Review

This pull request correctly addresses a LateInitializationError crash by adding guards to the stop() and stopRecorder() methods. While this is a good step, the current implementation introduces a subtle but critical race condition. The _status variable is updated before the background service is fully configured, which could lead to other errors if these methods are called during the asynchronous initialization process. My review includes critical comments that detail this issue and propose a more robust solution to ensure the service's stability.

[gemini-code-assist]

While this guard prevents the LateInitializationError, a race condition still exists. The init() method is async and sets _status to initiated before awaiting the _service.configure() call. This means stop() could be called after _service is instantiated but before it's fully configured. Calling invoke() on an unconfigured service can lead to unpredictable behavior or other errors.

To fix this properly, _status should only be set after _service.configure() has completed. This ensures that any method guarded by _status == null will only proceed when the service is fully initialized and configured.

Here is the recommended change for the init() method:

Future<void> init() async {
  _service = FlutterBackgroundService();
  // The status should not be set here.

  await _service.configure(
    // ... configurations
  );

  // Set status only after configuration is complete.
  // Also, the redundant status assignment at the end of the original method can be removed.
  _status = BackgroundServiceStatus.initiated;
}

Since the init() method is not part of this PR's changes, I'm providing this feedback here. Addressing this is critical for service stability.

[gemini-code-assist]

This method has the same critical race condition as the stop() method. The _status == null check is insufficient because _status is set before the service is fully configured in the async init() method. This could lead to _service.invoke() being called on an unconfigured service.

Please see my comment on the stop() method for a detailed explanation and the recommended fix in the init() method to resolve this.