ConversationDetailProvider.conversation - No valid conversation crash#4536
Open
ConversationDetailProvider.conversation - No valid conversation crash#4536
Conversation
Extract nullable conversation lookup into conversationOrNull getter so callers can safely check for conversation existence before accessing it. Add hasConversation convenience getter. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request effectively addresses a crash that occurs when no conversation is available for a selected date. The changes in ConversationDetailProvider are well-designed: renaming the conversation getter to conversationOrNull and making it return null instead of throwing an error is a good pattern. The addition of the hasConversation getter provides a convenient and safe way for UI components to check for the existence of a conversation before attempting to access it. Preserving the original throwing behavior in the conversation getter ensures backward compatibility for existing code that relies on a non-null return value. The implementation is clean and directly solves the reported issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
conversationOrNullgetter that returns null instead of throwingStateErrorhasConversationconvenience getter for safe existence checksconversationgetter still throws for callers that expect non-null, but callers can now safely check firstCrash Stats
Test plan
🤖 Generated with Claude Code