UrlLauncherIOS Safari view controller load crash

[aaravgarg]

Summary

• Add try-catch around launchUrl with inAppBrowserView mode
• Fallback to external browser when Safari view controller fails to load
• Prevents crash when iOS Safari view controller encounters an error loading the URL

Crash Stats

• Events: 76
• Users affected: 40
• Crashlytics: View in Console

Test plan

• Verify in-app browser still opens URLs correctly
• Test fallback to external browser by simulating Safari view controller failure

🤖 Generated with Claude Code

[gemini-code-assist]

Code Review

This pull request addresses a crash on iOS when launching URLs in an in-app browser by adding a try-catch block and a fallback mechanism to an external browser. The change is straightforward and effectively prevents the crash. The included comment further improves the robustness of the URL launching logic by handling cases where launchUrl might fail without throwing an exception, which is a valuable enhancement.

[gemini-code-assist]

The current implementation correctly handles exceptions when launching the URL, which fixes the reported crash. However, launchUrl can also return false on failure without throwing an exception. In that case, the fallback to an external browser would not be triggered, leading to a silent failure.

To make the implementation more robust, we should also handle the false return value from launchUrl. The suggested change refactors the logic to catch both exceptions and false return values from the in-app launch attempt, and then proceeds to the fallback in either case.

    try {
      if (!await launchUrl(uri, mode: LaunchMode.inAppBrowserView)) {
        throw Exception('launchUrl returned false');
      }
    } catch (e) {
      Logger.debug('Failed to launch URL in-app, falling back: $e');

      try {
        if (!await launchUrl(uri, mode: LaunchMode.externalApplication)) {
          Logger.debug('Failed to launch URL externally, launchUrl returned false.');
        }
      } catch (e2) {
        Logger.debug('Failed to launch URL externally: $e2');
      }
    }

[mdmohsin7]

closed in #4628

[github-actions]

Hey @aaravgarg 👋

Thank you so much for taking the time to contribute to Omi! We truly appreciate you putting in the effort to submit this pull request.

After careful review, we've decided not to merge this particular PR. Please don't take this personally — we genuinely try to merge as many contributions as possible, but sometimes we have to make tough calls based on:

• Project standards — Ensuring consistency across the codebase
• User needs — Making sure changes align with what our users need
• Code best practices — Maintaining code quality and maintainability
• Project direction — Keeping aligned with our roadmap and vision

Your contribution is still valuable to us, and we'd love to see you contribute again in the future! If you'd like feedback on how to improve this PR or want to discuss alternative approaches, please don't hesitate to reach out.

Thank you for being part of the Omi community! 💜