PlatformService.executeIfSupportedAsync - HandshakeException crash

[aaravgarg]

Summary

• Catch HandshakeException in PlatformService.executeIfSupportedAsync to prevent crash
• Returns fallback value instead of crashing when TLS handshake fails during platform-specific async operations (analytics, Intercom, etc.)

Crash Stats

• Events: 120
• Users affected: 105
• Crashlytics: View in Console

Test plan

• Verify platform-specific async operations still work normally
• Test with network issues (should return fallback, not crash)

🤖 Generated with Claude Code

[gemini-code-assist]

Code Review

This pull request addresses a crash caused by an unhandled HandshakeException during asynchronous platform-specific operations. The fix involves adding a try-catch block to gracefully handle this exception and return a fallback value. I've suggested a small improvement to make the error handling more robust by catching the more general IOException, which would prevent similar crashes from other network-related issues.

[gemini-code-assist]

While catching HandshakeException fixes the specific crash reported, it would be more robust to catch the more general IOException. This would handle other network-related errors as well, such as SocketException (e.g., no internet connection) or other I/O errors, which seems to align with the goal of gracefully handling "network issues" as mentioned in the test plan. HandshakeException itself is a subtype of IOException.

Suggested change

	} on HandshakeException {
	} on IOException {

[mdmohsin7]

closed in #4628

[github-actions]

Hey @aaravgarg 👋

Thank you so much for taking the time to contribute to Omi! We truly appreciate you putting in the effort to submit this pull request.

After careful review, we've decided not to merge this particular PR. Please don't take this personally — we genuinely try to merge as many contributions as possible, but sometimes we have to make tough calls based on:

• Project standards — Ensuring consistency across the codebase
• User needs — Making sure changes align with what our users need
• Code best practices — Maintaining code quality and maintainability
• Project direction — Keeping aligned with our roadmap and vision

Your contribution is still valuable to us, and we'd love to see you contribute again in the future! If you'd like feedback on how to improve this PR or want to discuss alternative approaches, please don't hesitate to reach out.

Thank you for being part of the Omi community! 💜