fix(desktop): keep routine button actions quiet - #11369
Merged
Archit-lal merged 1 commit intoAug 10, 2026
Merged
Conversation
Remove app-wide click cues from navigation, submit, star, capture, and settings actions while retaining intentional arrival and completion sounds. Verified: xcrun swift test --package-path Desktop (4612 tests, 0 failures, 1 skipped); named omi-button-silence bundle navigation emitted no ui sound events. Failure-Class: none
Archit-lal
force-pushed
the
codex/fix-button-click-sounds
branch
from
August 10, 2026 16:56
e852e58 to
4ab324a
Compare
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
kodjima33
added a commit
that referenced
this pull request
Aug 10, 2026
#11373) ## Summary `Desktop Swift Release Compile` has been red on `main` since #11369 (strict-concurrency error only visible under the release lane's whole-module optimization), which fails the auto-release gate closed — no beta candidate has cut, so #11372 (and everything since the last tag) is not reaching users. `KnowledgeGraphToolSupport.ResolveOutcome` was non-Sendable (its `ClientGraph` carries `[String: Any]` JSON-shaped dictionaries) and is returned from a nonisolated async function. The dictionaries hold only locally-built immutable `String`/`[String]` values, so `ClientGraph` is now `@unchecked Sendable` with that contract documented at the declaration, and `ResolveOutcome` is `Sendable`. ## Verification - `xcrun swift build -c release --package-path Desktop` locally: **Build complete (353.8s), zero errors** — the exact lane that fails in CI. - No behavior change; type-level conformance only. Failure-Class: none <!-- This is an auto-generated description by cubic. --> <a href="https://cubic.dev/pr/BasedHardware/omi/pull/11373?utm_source=github" target="_blank" rel="noopener noreferrer" data-no-image-dialog="true"><picture><source media="(prefers-color-scheme: dark)" srcset="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://www.cubic.dev/buttons/review-in-cubic-light.svg"><img alt="Review in cubic" src="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"></picture></a> <!-- End of auto-generated description by cubic. -->
![https://www.cubic.dev/buttons/review-in-cubic-dark.svg"><source](https://www.cubic.dev/buttons/review-in-cubic-dark.svg"><source){kind=link}
![https://www.cubic.dev/buttons/review-in-cubic-light.svg"><img](https://www.cubic.dev/buttons/review-in-cubic-light.svg"><img){kind=link}
![https://www.cubic.dev/buttons/review-in-cubic-dark.svg"></picture></a](https://www.cubic.dev/buttons/review-in-cubic-dark.svg"></picture></a){kind=link}
Archit-lal
pushed a commit
to Archit-lal/omi
that referenced
this pull request
Aug 10, 2026
The release (whole-module) compile rejects returning the non-Sendable ResolveOutcome from nonisolated resolveDiscoveryText — debug builds do not, so this only surfaced in the Desktop Swift Release Compile gate, where it has blocked every beta candidate since BasedHardware#11369. ClientGraph carries only locally-built immutable String/[String] values inside [String: Any] JSON-shaped dictionaries, so it is @unchecked Sendable with that contract stated at the declaration. Verified: xcrun swift build -c release --package-path Desktop — Build complete (353s), zero errors. Failure-Class: none
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
Commit
e96821074cexpanded onboarding audio into app-wide interaction feedback and mapped navigation, commit, and capture cues toclick.m4a. Because those cues were called from common button paths and effects default to enabled, ordinary actions played a click. The capture cues also bypassed the pre-existing push-to-talk sound preference.Verification
xcrun swift test --package-path Desktop: 4,612 tests passed, 1 skipped, 0 failuresxcrun swift test --package-path Desktop --filter OmiUISoundTests: focused sound regression passespython3 desktop/macos/scripts/check_desktop_test_quality.py: passedOMI_APP_NAME=omi-button-silence ./run.sh --full --yolo --no-wait: built, signed, installed, and launched the named dev bundleomi-ctl; its isolated log contained noui sound:eventscodesign --verify --deep --strict /Applications/omi-button-silence.app: passeddesktop/macos/test.shalso ran its launcher-script checks, but its livetest-mounted-navigation-latency.shfixture failed because port 47777 was occupied by an unrelated legacy-shellomi-mainbundle that does not exposevisibleChatFirstRoute. The complete Swift package suite above passed independently.The normal pre-push hook was bypassed after it compared this fork branch to the fork's stale
origin/mainand incorrectly selected 1,178 unrelated files, failing on pre-existing missing documentation targets. The equivalent PR preflight was run explicitly against canonicalupstream/mainand passed all 19 selected checks.The regression expectation is grounded in the reported behavior and the named-bundle measurement above: routine navigation must produce no app-wide sound event.
Product invariants affected
Failure-Class: none