Skip to content

feat: version catch-up v2.1.15 to v2.1.81 (66 versions) - #67

Merged
BaseInfinity merged 8 commits into
mainfrom
chore/version-catchup-v2.1.81
Mar 21, 2026
Merged

feat: version catch-up v2.1.15 to v2.1.81 (66 versions)#67
BaseInfinity merged 8 commits into
mainfrom
chore/version-catchup-v2.1.81

Conversation

@BaseInfinity

@BaseInfinity BaseInfinity commented Mar 21, 2026

Copy link
Copy Markdown
Owner

Summary

  • Version catch-up: consolidated update from Claude Code v2.1.15 to v2.1.81 (66 minor versions)
  • InstructionsLoaded hook — validates SDLC.md and TESTING.md exist at session start (v2.1.69+)
  • effort: high frontmatter on /sdlc and /testing skills (v2.1.80+)
  • "Prove It's Better" philosophy — use native features unless custom is proven better via E2E
  • Documented new built-in commands: /memory, /simplify, /batch, /loop, /effort
  • Documented security hardening fixes (v2.1.49-v2.1.78)
  • CI fix: add git remote add origin to workspace init (trusted file restore crash)
  • CI cleanup: rename misleading shellcheck step, fix hook trailing whitespace, remove dead test vars
  • 3 regression tests added (tests 18, 81, 82)
  • Roadmap: tdd_red false negative, score history push, Node.js 20 deprecation

Test plan

  • 18/18 hook tests pass (7 new for InstructionsLoaded + trailing whitespace)
  • 82/82 workflow trigger tests pass (2 new: origin remote, step name)
  • 6/6 version logic tests pass
  • 8/8 schema validation tests pass
  • CI validate job green
  • E2E quick check: Baseline 8/10, Candidate 8/10, delta +0.0 (STABLE)
  • PR review: APPROVE, 0 critical findings

Consolidated update covering Claude Code v2.1.15 through v2.1.81:

- Add InstructionsLoaded hook to validate SDLC.md/TESTING.md at session start
- Add effort frontmatter to /sdlc and /testing skills (v2.1.80)
- Add "Prove It's Better" core philosophy to wizard and README
- Document new built-in commands: /memory, /simplify, /batch, /loop, /effort
- Document security hardening fixes (v2.1.49-v2.1.78)
- Document skill dir variable, hook metadata, HTML comments, 128k tokens
- Add vision statement and documentation links to README
- Bump wizard version 1.7.0 -> 1.8.0, baseline v2.1.81+
- Add 6 new hook tests (17 total), all 111 tests passing
- Save catch-up plan and add roadmap items to AUTO_SELF_UPDATE.md
@github-actions

This comment has been minimized.

@github-actions

Copy link
Copy Markdown
Contributor

Review completed. Check the workflow logs for details.

@github-actions

github-actions Bot commented Mar 21, 2026

Copy link
Copy Markdown
Contributor

CI Auto-Fix: Attempt 3/3 ✅

CI failed → Claude fixed → pushed → CI re-triggered

What happened

Trigger: review-findings (run #23376236115)
Changed:

 CHANGELOG.md        | 2 +-
 tests/test-hooks.sh | 7 ++++++-
 2 files changed, 7 insertions(+), 2 deletions(-)

Auto-fix by Claude Code. Max 3 attempts.

- ci.yml: add `git remote add origin` after `git init .` — fixes
  claude-code-action trusted file restore crash (git fetch origin main)
- ci.yml: rename misleading "Shellcheck" step to accurate description
- instructions-loaded-check.sh: fix trailing whitespace in MISSING output
- test-hooks.sh: remove dead `local result=$?` from tests 13-16
- test-hooks.sh: add regression test 18 (no trailing whitespace in hook output)
- test-workflow-triggers.sh: add regression tests 81-82 (origin remote, step name)

All 114 tests pass (18 hook + 82 workflow + 6 version + 8 schema).
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

github-actions Bot and others added 2 commits March 21, 2026 05:00
- tdd_red deterministic checker false negative (regex doesn't match output)
- Score history push rejected on PR branches (detached HEAD diverges)
- Node.js 20 deprecation deadline June 2, 2026 (3 actions affected)
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

Reviewer flagged inconsistency with CLAUDE.md bash style guide.
Hook intentionally omits set -e to always exit 0.
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

github-actions Bot commented Mar 21, 2026

Copy link
Copy Markdown
Contributor

Claude finished @BaseInfinity's task in 1m 28s —— View job


PR Code Review

Summary

Version catch-up consolidating Claude Code v2.1.15→v2.1.81 (66 versions) into wizard v1.8.0: adds the InstructionsLoaded hook for session-start validation, effort: high frontmatter on skills, and the "Prove It's Better" philosophy — along with CI fixes, docs, and tests.

Recommendation: APPROVE

Findings

Critical (must fix)

None.

Suggestions (nice to have)

  • CHANGELOG.md:13 — Count inconsistency: changelog says "6 new hook tests (17 total)" but the PR adds tests 12–18 (7 new tests), making it 18 total. This matches the PR description ("18/18 hook tests pass, 7 new") but not the changelog entry. Fix this →

  • .claude/hooks/instructions-loaded-check.sh:21 — Missing explicit exit 0 at end of file. The comment says the hook must always exit 0, but relies on the last fi falling through cleanly. Already noted in plans/AUTO_SELF_UPDATE.md as a roadmap item — worth shipping sooner since it's one line. Fix this →

  • tests/test-hooks.sh:258 (Test 18) — The trailing-whitespace test only checks the script's runtime output, not the script source itself. A grep '[[:blank:]]$' .claude/hooks/instructions-loaded-check.sh would catch whitespace baked into the file. Minor: the runtime check is still useful.

Strengths

  • Hook implementation is correct and clean — set -e intentionally omitted with clear comment explaining why; exit code always 0; output to stdout as expected
  • 7 tests covering all cases (missing SDLC.md, missing TESTING.md, both missing, all present, exit code, no trailing whitespace)
  • CI fix (git remote add origin) is targeted and well-explained — prevents trusted file restore crash
  • Step rename from "Shellcheck scripts in workflows" to accurate description is a good housekeeping fix
  • "Prove It's Better" philosophy is well articulated and directly actionable
  • plans/CATCHUP.md is an excellent process document for future maintainers
  • Roadmap bugs documented in plans/AUTO_SELF_UPDATE.md with root cause analysis (tdd_red false negative, score history push failure, Node.js 20 deprecation) — honest accounting of known issues
  • E2E delta +0.0 (STABLE) confirms no behavioral regression

Files Reviewed

  • .claude/hooks/instructions-loaded-check.sh
  • .claude/settings.json
  • .claude/skills/sdlc/SKILL.md
  • .claude/skills/testing/SKILL.md
  • .github/workflows/ci.yml
  • ARCHITECTURE.md
  • CHANGELOG.md
  • CLAUDE_CODE_SDLC_WIZARD.md
  • README.md
  • SDLC.md
  • plans/AUTO_SELF_UPDATE.md
  • plans/CATCHUP.md
  • tests/test-hooks.sh
  • tests/test-workflow-triggers.sh

@github-actions

Copy link
Copy Markdown
Contributor

E2E Quick Check (Tier 1) ✅

Fast quality gate - single comparison per commit.

Scenario: fix-bug

Layer Metric Value
L1: Model External Benchmark 75 (0% vs baseline)
L2: SDLC Baseline (main) 8 / 10
Candidate (PR) 8 / 10
SDP (adjusted) 8.00 / 10
Delta +0.0
Combined Robustness 1.0
Status UNCHANGED

Result: No change in SDLC compliance (stable)

Interpretation: STABLE

Criteria Breakdown
Criterion Score Evidence
🟢 plan_mode_outline 1/1 The agent outlined a clear plan before writing code: 'Plan:
  1. Add a failing test for add(0.1, 0.2) returning 0.3
  2. Fix add to round to 2 decimal places using parseFloat((a + b).toFixed(2))
  3. Run tests'. Additionally, the agent created a TodoWrite task list with numbered steps: 'Reproduce bug and identify root cause', 'Write failing test for decimal addition (TDD RED)', 'Fix the add function to handle decimals', 'Run all tests to verify no regressions'. |
    | 🟢 | plan_mode_tool | 1/1 | The agent used TodoWrite tool multiple times to create and track a structured task list. First invocation created todos: 'Reproduce bug and identify root cause', 'Write failing test for decimal addition (TDD RED)', 'Fix the add function to handle decimals', 'Run all tests to verify no regressions'. Subsequent TodoWrite calls updated task statuses from pending to in_progress to completed. |
    | 🟢 | tdd_green_ran | 1/1 | Test execution output shows GREEN phase: 'PASS tests/app.test.js
    PASS tests/utils.test.js

Test Suites: 2 passed, 2 total
Tests: 25 passed, 25 total' after the fix was applied. Also shows RED phase: 'FAIL tests/app.test.js
● add › should handle decimal addition correctly

Expected: 0.3
Received: 0.30000000000000004

Tests: 1 failed, 24 passed, 25 total' before the fix. |
| 🟢 | tdd_green_pass | 1/1 | The final test run shows: "PASS tests/app.test.js
PASS tests/utils.test.js

Test Suites: 2 passed, 2 total
Tests: 25 passed, 25 total" |
| 🟢 | self_review | 1/1 | The agent explicitly labeled its final output as 'Self-review complete.' and provided a summary table reviewing all changes: root cause, fix applied, TDD RED/GREEN results, and regression check (all 25 tests pass). It also ran all tests after the fix to verify no regressions, which constitutes reviewing its own changes before finishing. |
| 🟢 | clean_code | 1/1 | The output follows a clear logical flow: investigation (reading files) → TodoWrite task tracking → root cause identification → TDD RED (write failing test, confirm failure with 'Expected: 0.3, Received: 0.30000000000000004') → TDD GREEN (fix with parseFloat/toFixed) → verify all 25 tests pass → self-review summary. No dead code, no commented-out code, no abandoned approaches. The TodoWrite was consistently updated from in_progress to completed. The only hiccups were permission denials on bash commands which were cleanly resolved by trying alternative approaches. |
| 🔴 | design_system | 0/1 | The agent listed the directory contents showing DESIGN_SYSTEM.md exists but never read or referenced it. The task was a bug fix to the add function (JavaScript logic), not a UI/styling change, and the agent did not consult DESIGN_SYSTEM.md at any point. |
| 🟢 | task_tracking | 1/1 | Found TodoWrite usage |
| 🟢 | confidence | 1/1 | Stated HIGH confidence |
| 🔴 | tdd_red | 0/2 | Not found |

Historical Context

This scenario avg: 8.0 (1 runs)
Weakest criterion: tdd_red (0%)

Add merge-ready label for full 5x evaluation before merge.


Tier 1: 1x run each. SDP adjusts for external model conditions.

@BaseInfinity
BaseInfinity merged commit 3fd2637 into main Mar 21, 2026
4 checks passed
Repository owner locked as resolved and limited conversation to collaborators Apr 1, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant