v1.39.0: community scanner (#207) + dead plugin cleanup - #245
Merged
Conversation
Replaces the deleted CI scan-community job (per #231 Phase 3 plan) with a maintainer-runnable offline scan. Extracts /[a-z][a-z0-9-]* slash-command mentions from transcript text (Reddit / HN / Discord exports), dedupes against tests/e2e/known-slash-commands.txt allowlist, emits JSON digest of unknown candidates. - tests/e2e/scan-community.sh: scanner script. Lowercases line before matching (case-insensitive); sample window is centered on the matched slash so long-line context isn't truncated; reads files via 'cat < "$arg"' so dash-leading filenames work. - tests/e2e/known-slash-commands.txt: allowlist seeded with wizard skills, CC native commands, and common URL-path false positives. Plain text format with # comments; maintainer appends as new commands ship. - tests/test-community-scanner.sh: 14 tests covering detection, allowlist filter (CC native + wizard skills), case-insensitive extraction, dedup + count, empty-input edge case, JSON shape, stdin input, multi-file aggregation, sample-context inclusion, long-line sample window, dash-leading filename. - CLAUDE_CODE_SDLC_WIZARD.md: new "Community Feature-Discovery Scanner" subsection with maintainer procedure (capture transcripts → run scanner → triage `jq .candidates`). - CHANGELOG, version bump 1.38.0 → 1.39.0 across package.json, plugin.json, marketplace.json, SDLC.md, CLAUDE_CODE_SDLC_WIZARD.md version comments, and skills/update/SKILL.md Step 3 example. Codex 3-round review: round 1 6/10 NOT CERTIFIED (orphan tests not in CI, case-sensitive extraction, sample truncation can drop slash, stale 1.38.0 in update skill, dash-leading filename), round 2 8/10 NOT CERTIFIED (5 findings FIXED but git index UU pending), round 3 10/10 CERTIFIED.
When wizard-installed plugin marketplace dirs are renamed/disabled/ removed but the registration in ~/.claude/settings.json stays, every CC session emits "UserPromptSubmit hook error: Plugin directory does not exist". Discovered live in Stefan's session today after the v1.37.1 dual-channel dedupe naturally led to disabling the plugin wrap. New Step 7.7 in /update-wizard: - Exact wizard-owned marketplace allowlist (sdlc-wizard-local, sdlc-wizard-wrap) — no wildcard, prevents eating third-party sdlc-* prefixed plugins - Detection requires source.source == "directory" AND typeof source.path === "string" before fs check (matches cli/init.js guard) - Collects all dead pairs before prompting; single jq pass to drop all of them in one transaction - Backup uses $(date +%Y%m%dT%H%M%S) so multiple cleanups same day don't overwrite each other - Doesn't claim byte-for-byte preservation (jq normalizes); offers manual del() filter to users who care about exact diff - Idempotent: re-run after cleanup is a no-op Codex 2-round: round 1 6/10 (5 findings — broad wildcard, impossible byte-for-byte claim, non-idempotent backup, singular cleanup wording, missing type guard), round 2 100/100 CERTIFIED.
3 tasks
Contributor
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
BaseInfinity
added a commit
that referenced
this pull request
May 5, 2026
* feat(#207): community feature-discovery scanner — v1.39.0 Replaces the deleted CI scan-community job (per #231 Phase 3 plan) with a maintainer-runnable offline scan. Extracts /[a-z][a-z0-9-]* slash-command mentions from transcript text (Reddit / HN / Discord exports), dedupes against tests/e2e/known-slash-commands.txt allowlist, emits JSON digest of unknown candidates. - tests/e2e/scan-community.sh: scanner script. Lowercases line before matching (case-insensitive); sample window is centered on the matched slash so long-line context isn't truncated; reads files via 'cat < "$arg"' so dash-leading filenames work. - tests/e2e/known-slash-commands.txt: allowlist seeded with wizard skills, CC native commands, and common URL-path false positives. Plain text format with # comments; maintainer appends as new commands ship. - tests/test-community-scanner.sh: 14 tests covering detection, allowlist filter (CC native + wizard skills), case-insensitive extraction, dedup + count, empty-input edge case, JSON shape, stdin input, multi-file aggregation, sample-context inclusion, long-line sample window, dash-leading filename. - CLAUDE_CODE_SDLC_WIZARD.md: new "Community Feature-Discovery Scanner" subsection with maintainer procedure (capture transcripts → run scanner → triage `jq .candidates`). - CHANGELOG, version bump 1.38.0 → 1.39.0 across package.json, plugin.json, marketplace.json, SDLC.md, CLAUDE_CODE_SDLC_WIZARD.md version comments, and skills/update/SKILL.md Step 3 example. Codex 3-round review: round 1 6/10 NOT CERTIFIED (orphan tests not in CI, case-sensitive extraction, sample truncation can drop slash, stale 1.38.0 in update skill, dash-leading filename), round 2 8/10 NOT CERTIFIED (5 findings FIXED but git index UU pending), round 3 10/10 CERTIFIED. * feat(update-skill): dead plugin registration cleanup (Step 7.7) When wizard-installed plugin marketplace dirs are renamed/disabled/ removed but the registration in ~/.claude/settings.json stays, every CC session emits "UserPromptSubmit hook error: Plugin directory does not exist". Discovered live in Stefan's session today after the v1.37.1 dual-channel dedupe naturally led to disabling the plugin wrap. New Step 7.7 in /update-wizard: - Exact wizard-owned marketplace allowlist (sdlc-wizard-local, sdlc-wizard-wrap) — no wildcard, prevents eating third-party sdlc-* prefixed plugins - Detection requires source.source == "directory" AND typeof source.path === "string" before fs check (matches cli/init.js guard) - Collects all dead pairs before prompting; single jq pass to drop all of them in one transaction - Backup uses $(date +%Y%m%dT%H%M%S) so multiple cleanups same day don't overwrite each other - Doesn't claim byte-for-byte preservation (jq normalizes); offers manual del() filter to users who care about exact diff - Idempotent: re-run after cleanup is a no-op Codex 2-round: round 1 6/10 (5 findings — broad wildcard, impossible byte-for-byte claim, non-idempotent backup, singular cleanup wording, missing type guard), round 2 100/100 CERTIFIED.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #244 (stale rebase). Same content, fresh PR from rebased branch.
Summary
tests/e2e/scan-community.sh) — extracts unknown/slash-commandmentions from transcripts, dedupes against allowlist, emits JSON digest. CERTIFIED 10/10 round 3./update-wizardnow scans~/.claude/settings.jsonfor orphan registrations matching the allowlist (sdlc-wizard-local,sdlc-wizard-wrap), backs up settings with timestamp, removes via single jq pass. CERTIFIED 100/100 round 2. Fixes theUserPromptSubmit hook error: Plugin directory does not existthat fires on every prompt for users with stale local-marketplace registrations.Test plan
tests/test-community-scanner.sh— 14 tests (detection, allowlist, dedup, JSON shape, stdin, multi-file, sample context, long-line, case-insensitive, dash-leading filenames)tests/test-update-skill-step-7-7.sh— Step 7.7 cleanup testsWhy a new PR
PR #244 was opened from
roadmap-207-community-scannerbefore the rebase. After resolving conflicts and stacking the Step 7.7 cleanup on top, force-push was blocked. This PR ships the same content from the clean rebased branch.