Skip to content

merge gate: round>=2 blocks the one case where the review was cleanest #563

Description

@BaseInfinity

scripts/merge-pr.sh requires round >= 2 in the clearance artifact. The intent is sound — one round is usually a rubber stamp, and the dialogue is where the review actually happens.

But it conflates dialogue happened with review was adversarial, and those come apart in exactly one case: both reviewers certify at round 1 with zero findings.

That happened on PR #562 (#525). Sol: SHAPE SOUND, zero at P0/P1/P2/P3, 99%. Fable: no findings at any severity, 97%. Both independently verified the evidence cite against primary sources; Fable swept every shipped surface for contradicting rules. There was nothing to dispute, so there was nothing for a round 2 to be about.

The only way to satisfy the gate from there is to invoke both reviewers again and ask them to re-verify nothing — ceremony that increments a counter and buys no signal. That is the same class as the round cap this milestone already retired and the prompt classifier #561 deletes.

Two independent clean certifications is stronger evidence than one two-round dialogue, and the gate reads it as weaker.

Proposed: round >= 2 OR (round == 1 AND two or more reviewers certified with zero findings at every severity). The zero-findings condition is mechanical — it reads the clearance artifact, not prose — so it has a writable RED (a clearance with one P3 recorded must still demand round 2).

Blocked behind #540, which is rewriting the same artifact's contract.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions