Verify TestDouble call counts #13
Open
+377
−153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add a method for assert.calledTimes(number)
* add a property for assert.calledOnce, assert.calledTwice, assert.calledThrice
* restructuring and updating the code, in particular using const/let, destructuring, and arrow function 'this' semantics.
|
Hey @cwilbur thank you for this awesome PR! I haven't looked at this project in quite some time (hence my slow reply), so it'll take me a minute to get things set back up to review this properly, but I will set aside time for that this week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added code to verify the number of times a test double was called, and brought the existing code up to date with current practices. I added tests and updated the documentation as well.
If there's something about it you don't like or would prefer done another way, let me know. I'm not dogmatic, and I'd be happy to change it.