Skip to content

Commit

Permalink
data conversion, not data conversation
Browse files Browse the repository at this point in the history
* we're not talking to the data yet ...
  • Loading branch information
xmatthias committed Jan 5, 2020
1 parent 2409261 commit f82c434
Show file tree
Hide file tree
Showing 6 changed files with 13 additions and 13 deletions.
8 changes: 4 additions & 4 deletions docs/data-download.md
Original file line number Diff line number Diff line change
Expand Up @@ -78,9 +78,9 @@ optional arguments:
Show profits for only these pairs. Pairs are space-
separated.
--format-from {json,jsongz}
Source format for data conversation.
Source format for data conversion.
--format-to {json,jsongz}
Destination format for data conversation.
Destination format for data conversion.
--erase Clean all existing data for the selected
exchange/pairs/timeframes.
-t {1m,3m,5m,15m,30m,1h,2h,4h,6h,8h,12h,1d,3d,1w} [{1m,3m,5m,15m,30m,1h,2h,4h,6h,8h,12h,1d,3d,1w} ...], --timeframes {1m,3m,5m,15m,30m,1h,2h,4h,6h,8h,12h,1d,3d,1w} [{1m,3m,5m,15m,30m,1h,2h,4h,6h,8h,12h,1d,3d,1w} ...]
Expand Down Expand Up @@ -127,9 +127,9 @@ optional arguments:
Show profits for only these pairs. Pairs are space-
separated.
--format-from {json,jsongz}
Source format for data conversation.
Source format for data conversion.
--format-to {json,jsongz}
Destination format for data conversation.
Destination format for data conversion.
--erase Clean all existing data for the selected
exchange/pairs/timeframes.
Expand Down
8 changes: 4 additions & 4 deletions freqtrade/configuration/arguments.py
Original file line number Diff line number Diff line change
Expand Up @@ -264,14 +264,14 @@ def _build_subcommands(self) -> None:
convert_data_cmd.set_defaults(func=partial(start_convert_data, ohlcv=True))
self._build_args(optionlist=ARGS_CONVERT_DATA_OHLCV, parser=convert_data_cmd)

# Add convert-data subcommand
convert_data_cmd = subparsers.add_parser(
# Add convert-trade-data subcommand
convert_trade_data_cmd = subparsers.add_parser(
'convert-trade-data',
help='Convert trade-data from one format to another.',
parents=[_common_parser],
)
convert_data_cmd.set_defaults(func=partial(start_convert_data, ohlcv=False))
self._build_args(optionlist=ARGS_CONVERT_DATA, parser=convert_data_cmd)
convert_trade_data_cmd.set_defaults(func=partial(start_convert_data, ohlcv=False))
self._build_args(optionlist=ARGS_CONVERT_DATA, parser=convert_trade_data_cmd)

# Add Plotting subcommand
plot_dataframe_cmd = subparsers.add_parser(
Expand Down
4 changes: 2 additions & 2 deletions freqtrade/configuration/cli_options.py
Original file line number Diff line number Diff line change
Expand Up @@ -334,13 +334,13 @@ def __init__(self, *args, **kwargs):
),
"format_from": Arg(
'--format-from',
help='Source format for data conversation.',
help='Source format for data conversion.',
choices=constants.AVAILABLE_DATAHANDLERS,
required=True,
),
"format_to": Arg(
'--format-to',
help='Destination format for data conversation.',
help='Destination format for data conversion.',
choices=constants.AVAILABLE_DATAHANDLERS,
required=True,
),
Expand Down
2 changes: 1 addition & 1 deletion freqtrade/data/history/history_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ def _load_cached_data_for_updating(pair: str, timeframe: str, timerange: Optiona
start = None
if timerange:
if timerange.starttype == 'date':
# TODO: convert to date for conversation
# TODO: convert to date for conversion
start = datetime.fromtimestamp(timerange.startts, tz=timezone.utc)

# Intentionally don't pass timerange in - since we need to load the full dataset.
Expand Down
2 changes: 1 addition & 1 deletion freqtrade/data/history/idatahandler.py
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ def _ohlcv_load(self, pair: str, timeframe: str,
) -> DataFrame:
"""
Internal method used to load data for one pair from disk.
Implements the loading and conversation to a Pandas dataframe.
Implements the loading and conversion to a Pandas dataframe.
Timerange trimming and dataframe validation happens outside of this method.
:param pair: Pair to load data
:param timeframe: Ticker timeframe (e.g. "5m")
Expand Down
2 changes: 1 addition & 1 deletion freqtrade/data/history/jsondatahandler.py
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ def _ohlcv_load(self, pair: str, timeframe: str,
) -> DataFrame:
"""
Internal method used to load data for one pair from disk.
Implements the loading and conversation to a Pandas dataframe.
Implements the loading and conversion to a Pandas dataframe.
Timerange trimming and dataframe validation happens outside of this method.
:param pair: Pair to load data
:param timeframe: Ticker timeframe (e.g. "5m")
Expand Down

0 comments on commit f82c434

Please sign in to comment.