fix(core): do not create empty header entries in routeRules

[vejja]

Types of changes

• Bug fix (a non-breaking change which fixes an issue)
• New feature (a non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Description

Fixes #538

The getHeadersApplicableToAllRessources was previously returning an empty object {} when no eligible entry was found, which resulted in an empty headers: {} entry in the routeRules registry.

This could trigger a deployment failure in some Nitro presets (e.g. Vercel).

This PR ensures that no headers entry is created in the corresponding routeRule in that case, fixing the bug described in #538.

Checklist:

• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my changes (if not applicable, please state why)

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
nuxt-security	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 25, 2024 9:44am

[maxdzin]

@vejja I tried to make a build of this branch locally (dev:build) and it failed with this error:

Error: ENOENT: no such file or directory, open './.nuxt/server.headers'

Am I missing something?

[vejja]

@vejja I tried to make a build of this branch locally (dev:build) and it failed with this error:

Error: ENOENT: no such file or directory, open './.nuxt/server.headers'

Am I missing something?

I think you are building the playground and hitting the prerenderedHeaders hook. Strange thing that it couldn't write to ./.nuxt/server.headers...
Anyway, just do prepack instead to build the module distributable

[maxdzin]

@vejja Yes, I did prepack as well and it fails with this error:

ERROR  failed to resolve "extends":"./.nuxt/tsconfig.json" in /.../nuxt-security/tsconfig.json

It could be something due to the environment.

[vejja]

@maxdzin here is the build for the local tests. Let me know !
dist.zip

[maxdzin]

@vejja Nice! Thank you
I tried that and confirm that it working well. The headers were passed as expected.

[Baroshem]

One small suggestion, apart from that ready to be merged :)