Fix barcode size consistency issue - ensure uniform image heights for Code128 #25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The barcode generation API was producing inconsistent image dimensions for Code128 barcodes, even when using identical parameters. This affected user experience and made it difficult to maintain consistent layouts.
Inconsistent behavior observed:
/api/128/12345
→ 234x130 pixels/api/128/25000
→ 234x168 pixels/api/128/25000?height=22
→ Still inconsistent dimensionsRoot Cause
The issue stemmed from the barcode4j library's dimension calculation logic. The total image height was computed as:
Total Height = Bar Height + Text Height + Spacing
Different barcode content could result in varying text layout calculations, causing inconsistent total image heights even when the
height
parameter (which controls bar height) was identical.Solution
Modified
BarcodeCanvasProvider.establishDimensions()
to implement dimension standardization:Key Changes
createStandardizedDimension()
- Normalizes BarcodeDimension objects for consistent sizingTesting
Added comprehensive test coverage:
Test Results:
Impact
This surgical fix resolves the dimension inconsistency while preserving all existing functionality and maintaining backward compatibility.
Fixes #24.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.