Proposal: Use pre-commit hook for linting and prettier

[Oktalize]

Description

I am a big fan of consistency when working in a repo as a team. The biggest issue I run into is that sometimes people forget to lint & format before they make a commit, and they end up not finding out about their issues until they get to the PR. Also dealing with formatting changes (like tabs vs spaces), can make for some unnecessary merge changes.

Solution

Utilize the husky to implement a pre-commit hook to run type-check, lint, and prettier whenever a commit is made. This would prevent anyone from making a commit with bad code.

Downside

You will hate yourself for not finding a silly type/linting error and having to fix it before your commit is made.

[Oktalize]

I want to get everyone's thoughts on this before I go ahead and implement this. I am familiar with setting this up so let me know.

The setup might be a bit complex with yarn workspaces but I think it's still possible, just gotta figure out to only trigger it for react-app to avoid wasting time when changes are committed to files in the truffle package.

[Oktalize]

This will be closed when the PR is merged. I have configured husky to run on pre-commit hooks. The hook will run yarn lint which is only going to run type-check, lint, and prettier when a new commit is made to the react-app package. This is ran entirely within the react-app package, so it won't change anything in truffle. If any changes are made to the truffle package, then it will be skipped because no changes were found in the react-app package.