Verse - Voice builder pattern and typing #71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @ethanransdellverse - thanks for this contribution! Greatly appreciated. I will take a look and get the changes merged in! We release on Tuesdays - so you can expect to see these in the next version released on 7/9 |
|
It does look like this would break our support for 7.4 (which is long since EOL) I think that its ok to merge in, and we can release as a new major version. Will discuss with my team but i think that itll be fine for this to go out Tuesday as v11 |
ajrice6713
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After working with this SDK for our Voice implementation, I found it would be helpful to support the builder pattern for verbs. I also added stronger typing, found a missing variable declaration, and implemented
__toString()in the voice response object. For your consideration!