Skip to content

SWI-2615 #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 24, 2023
Merged

SWI-2615 #64

merged 5 commits into from
May 24, 2023

Conversation

ajrice6713
Copy link
Contributor

Closes #62

@ajrice6713 ajrice6713 requested a review from a team May 17, 2023 19:16
@ajrice6713 ajrice6713 marked this pull request as draft May 17, 2023 19:16
@ajrice6713 ajrice6713 marked this pull request as ready for review May 17, 2023 19:18
@ajrice6713 ajrice6713 marked this pull request as draft May 17, 2023 19:59
ajrice6713 added 2 commits May 17, 2023 17:02
@ajrice6713
Attempt to automate adding all type hints to remove warnings
d2d385d 
Used IntelliJ and a PHP plugin to automate all of this w/ some manual intervention in the BXML library
@ajrice6713
more sleep
9d89bc8
@ajrice6713 ajrice6713 mentioned this pull request May 17, 2023
Closed
@ajrice6713 ajrice6713 marked this pull request as ready for review May 24, 2023 11:59
@ajrice6713 ajrice6713 merged commit 26c9b5d into main May 24, 2023
@ajrice6713 ajrice6713 deleted the SWI-2615 branch May 24, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianluisgomez brianluisgomez brianluisgomez approved these changes

@ckoegel ckoegel ckoegel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Class method return types needed for >8.0 support
3 participants
@ajrice6713 @brianluisgomez @ckoegel