DX-1855 added php tests #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamermike
approved these changes
Apr 7, 2021
ajrice6713
reviewed
Apr 8, 2021
.github/workflows/validate.yml
Outdated
| ACCOUNT_ID: ${{ secrets.ACCOUNT_ID }} | ||
| VOICE_APPLICATION_ID: ${{ secrets.VOICE_APPLICATION_ID }} | ||
| MESSAGING_APPLICATION_ID: ${{ secrets.MESSAGING_APPLICATION_ID }} | ||
| CALLBACK_URL: ${{ secrets.CALLBACK_URL }} |
There was a problem hiding this comment.
What's being returned from CALLBACK_URL? It looks like this is only used for voice callbacks - maybe we should rename to VOICE_CALLBACK_URL to be explicit, and for my knowledge what BXML is being returned from this to keep the call alive?
There was a problem hiding this comment.
Yeah good callout. It is just for voice so renaming it would make more sense. No BXML is being returned because this is just checking to make sure that the call is created
ajrice6713
approved these changes
Apr 8, 2021
ajrice6713
approved these changes
Apr 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.