minor

BanDroid · May 17, 2023 · 7fee07c · 7fee07c
1 parent b76366c
commit 7fee07c
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/examples/vike-react-simple/vite.config.js b/examples/vike-react-simple/vite.config.js
@@ -3,6 +3,6 @@ import ssr from 'vite-plugin-ssr/plugin'
 
 export default {
   plugins: [react(), ssr()],
-  // TODO: why is this needed?
+  // TODO: remove need for this
   optimizeDeps: { include: ['vike-react-simple/onRenderClient'] }
 }
diff --git a/vite-plugin-ssr/node/plugin/plugins/importUserCode/v1-design/getConfigData.ts b/vite-plugin-ssr/node/plugin/plugins/importUserCode/v1-design/getConfigData.ts
@@ -1,5 +1,11 @@
 export { getConfigData }
 
+// TODO
+//  - refactor virtual module HMR invalidation
+//  - gracefullly handle errors in getConfigData()
+//    - Remove markAsUserLandError()?
+//  - Remove need for `optimizeDeps: { include: ['vike-react-simple/onRenderClient'] }` in /examples/vike-react-simple/
+
 import {
   assertPosixPath,
   assert,