Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gif Enhancement #26

Closed
wants to merge 7 commits into from
Closed

Gif Enhancement #26

wants to merge 7 commits into from

Conversation

SCR01
Copy link
Contributor

@SCR01 SCR01 commented Oct 3, 2024

Title:

Gif Change

Description:

Problem:
The previous gif doesn't offer much animation and doesn't catch the user's attention.

Solution:

  • Replaced the existing gif with a more animated and engaging version.
  • The new gif is set at a resolution of 700x394 to fit the required dimensions.

Issue Reference:
This PR addresses Issue No. 15.

Comment:

This change is aimed at improving user engagement by using a more animated gif, enhancing the visual appeal of the platform.

Allow edits by maintainers:
✅

@SCR01
Copy link
Contributor Author

SCR01 commented Oct 4, 2024

@BamaCharanChhandogi Check it, too.

BamaCharanChhandogi
BamaCharanChhandogi requested changes Oct 5, 2024
View reviewed changes
Copy link
Owner

@BamaCharanChhandogi BamaCharanChhandogi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whu did you add extra file(Hero.jsx) code? redo the changes then I will review.

SCR01
SCR01 commented Oct 5, 2024
View reviewed changes
Copy link
Contributor Author

@SCR01 SCR01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I reviewed the changes and deleted the Hero.jsx file.

@SCR01 SCR01 closed this Oct 5, 2024
@SCR01 SCR01 deleted the gif_change branch October 5, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BamaCharanChhandogi BamaCharanChhandogi BamaCharanChhandogi requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SCR01 @BamaCharanChhandogi