Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BAH-3181 | Configuration support for concept name label to be shown on FSN if specified #792

Merged
merged 2 commits into from
Dec 7, 2023

Conversation

angshu
Copy link
Member

@angshu angshu commented Dec 1, 2023

Configuration support in Obs display control ("displayNameType"), so that the concept name labels can be shown in FSN. If nothing specified default behavior of showing in SN (or FSN in SN is not available) is retained.
For example:

"basicVitals": { "translationKey": "XYZ", "type": "observation", "isObservation": true, "displayOrder": 6, "dashboardConfig": { "conceptNames": [ "Height (cm)", "Weight (kg)", "Body mass index", "BMI Status" ], "showDetailsButton": true, "numberOfVisits": 3, "displayNameType": "FSN" }, "hideEmptyDisplayControl": true }

This also resolves the bug where in non-implementation locale usage by user (e,g. default locale = en, user locale = french), the obs display control would not show non-matching concept names, even though the API returned the right data.

…n FSN or default SN

"conceptFSN" configuration support in Obs display control, so that the concept name labels can be shown in FSN.
If nothing specified default behavior of showing in SN (or FSN in SN is not available) is retained.

This also resolves the bug where in non-implementation locale usage by user (e,g. default locale = en, user locale = french), the obs display control would not show non-matching concept names, even though the API returned the right data.
@mohan-13
Copy link
Member

mohan-13 commented Dec 5, 2023

@angshu In reference to this PR in bahmni-core, we would need to pass on the current user selected locale while making /bahmnicore/observations API call from frontend right ? Or is that handled in some other way ?

@mohan-13 mohan-13 merged commit bb56ce5 into master Dec 7, 2023
2 checks passed
@mohan-13 mohan-13 deleted the BAH-3181-3 branch December 7, 2023 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants