BAH-1240 | Removing check for response head. Oviyam sends a redirect URL which can be HTTP depending on setup, and in that case browser thrrows error for CORS #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…L in some cases and they happen to be HTTP (if behind a reverse proxy), and browser without CORS header does not follow the URL
… for repo in package json
|
[From Angshu] We were checking using ajax request for HEAD to see if there was any result. However, oviyam being behind apache and sees the connection coming in in plain HTTP, and the redirection (302) can not be followed by the browser because of same origin policy (which we put in this release). As a result the study is not opened up. |
gsluthra
approved these changes
Sep 17, 2021
angshu
added a commit
that referenced
this pull request
Sep 17, 2021
…URL which can be HTTP depending on setup, and in that case browser thrrows error for CORS (#377) * BAH-1240 | Removing check for response, as Oviyam sends a redirect URL in some cases and they happen to be HTTP (if behind a reverse proxy), and browser without CORS header does not follow the URL * Minor changes to message and relevant translation. also corrected URL for repo in package json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.