BAH-790 Functionality to view obs forms based on provider Types #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
binduak
requested changes
Dec 15, 2019
| var extensions = clinicalAppConfigService.getAllConceptSetExtensions($stateParams.conceptSetGroupName); | ||
| var configs = clinicalAppConfigService.getAllConceptsConfig(); | ||
| var visitType = configurations.encounterConfig().getVisitTypeByUuid($scope.consultation.visitTypeUuid); | ||
| $scope.context = {visitType: visitType, patient: $scope.patient}; | ||
| var enablePrivilegeTypeBasedFormsAccess = appService.getAppDescriptor().getConfigValue('enablePrivilegeTypeBasedFormsAccess'); |
There was a problem hiding this comment.
@krishnanspace
both enablePrivilegeTypeBasedFormsAccess and privilegeTypeBasedFormsAccess don't match with the one mentioned in the PR raised default-config.
binduak
reviewed
Dec 16, 2019
| privilegeNames.push(match[1]); | ||
| } | ||
| })); | ||
| return privilegeNames; |
There was a problem hiding this comment.
@krishnanspace What exactly does privilegeNames return ??
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To test this functionality this PR is also needed: Bahmni/default-config#38
This functionality depends on 2 configs mentioned in the above PR.
The first one is
enableProviderTypeBasedFormsAccesswhich is set to false by default. When its set to false, the regular functionality/workflow takes place i.e. All the Obs Forms are visible to the current provider.If it is set to true , the Provider Type Based access to forms is enabled i.e. a particular provider is only able to view the Obs forms assigned to them.
In the linked PR , there are 2 provider types: provider1 & provider2 and each have a particular set of forms that they can view.
For this to actually work, providerAttribute types have to be created in OpenMRS with the exact same names as the ones specified in the app.json file. The attribute datatype must be boolean.
Create multiple attributes as per your requirements. Then set the value of the attributes to true for your providers. For example, your Provider is called "Dr.John" who is of type "XYZ" then set the XYZ provider attribute for Dr.John to true.
This will ensure that Dr. John of type XYZ can only view the forms mentioned in the app.json config