-
-
Notifications
You must be signed in to change notification settings - Fork 95
Enhance Pode Shared State with Thread-Safe Structures and Improved Concurrency Handling #1473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mdaneri
wants to merge
48
commits into
Badgerati:develop
Choose a base branch
from
mdaneri:threadsafe-state
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
This was referenced Mar 9, 2025
Closed
This reverts commit 94ce3fa.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR introduces thread-safe shared state management in Pode, allowing developers to use more robust concurrent data structures without requiring explicit locking. Previously,
Lock-PodeObject
was mandatory for shared state variables, which could lead to performance bottlenecks and unnecessary complexity. With this update, Pode now supports natively thread-safe collections, reducing the risk of race conditions and improving overall execution efficiency.This update is fully backward compatible. All existing Pode implementations will continue to work as expected without requiring any modifications.
Why This Is Needed:
ConcurrentDictionary
,ConcurrentBag
, and more.Key Features & Changes:
Added Support for Thread-Safe Structures
ConcurrentDictionary
ConcurrentBag
ConcurrentQueue
ConcurrentStack
Added the
Set-PodeState -NewCollectionType
parameterThat allows users to specify the type of collection to initialize within the shared state. This eliminates the need to manually instantiate collections before setting them in the state.
Explicit Handling for Non-Thread-Safe Structures
Hashtable
,OrderedDictionary
, andPSCustomObject
now explicitly requireLock-PodeObject
for safe multi-threaded access.Fully Backward Compatible
Lock-PodeObject
will continue to work without modification.Updated Documentation & Examples
Example Usage:
Thread-Safe (No Locking Required)
Non-Thread-Safe (Locking Required)
Impact & Considerations:
Looking for Feedback On:
PR Link: #1474