Increase timeout for circuit breaker E2E tests#6
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR increases the timeout after gateway startup in the "circuit breaker can be disabled" test from 200ms to 1000ms. This change likely addresses a timing issue where the test was failing due to the gateway not being fully ready within the original 200ms timeout.
- Increased post-startup delay from 200ms to 1000ms for test stability
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| await gateway.listen() | ||
| await new Promise((r) => setTimeout(r, 200)) | ||
| await new Promise((r) => setTimeout(r, 1000)) |
There was a problem hiding this comment.
This test now uses a 1000ms delay while other similar tests in the same file use 200ms (lines 35, 82, 125). This inconsistency makes the test suite slower and harder to maintain. Consider either using the same 200ms delay for consistency, or if this test genuinely needs more time, add a comment explaining why this specific test requires a longer delay.
| await new Promise((r) => setTimeout(r, 1000)) | |
| await new Promise((r) => setTimeout(r, 200)) |
1 participant
No description provided.