Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds error handling for async middleware by catching Promise rejections and routing them to the error handler, along with a test to verify this functionality.
- Adds Promise rejection handling for async middleware functions
- Includes test coverage for async middleware error scenarios
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lib/next.js | Adds Promise.catch() handling for both router lookup and regular middleware functions |
| tests/router-coverage.test.js | Adds test case to verify async middleware errors are properly caught and handled |
Comments suppressed due to low confidence (1)
tests/router-coverage.test.js:372
- The parameter 'next' is declared but never used in this middleware function. Consider removing it or using an underscore prefix to indicate it's intentionally unused.
const middleware = async (req, res, next) => {
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
npm testhttps://chatgpt.com/codex/tasks/task_e_688a805bbfa88323a8f845b09662ccca