Conversation
Owner
|
thx! |
blaineam
pushed a commit
to blaineam/diffvg
that referenced
this pull request
Jun 27, 2022
fix radix sort bug (merging this in for testing)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If start with a fresh conda virtual env and following the installation instructions, I got the following error:
So it might be good to install cmake directly with conda.
Similarly, we need also
ffmpegto run the examples.Another minor thing is maybe we should add
-yafterconda installso one can basically copy and paste all the commands.