Resolve symlinks when loading app:/// and file:/// URLs on Windows #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The WinRT file API does not resolve symlinks when used in Win32 apps. This change replaces the WinRT file API with calls to C++ STL fstream functions which resolves symlinks on both UWP and Win32 builds.
docEdub
changed the title
docEdub
changed the title
bghgary
reviewed
Oct 2, 2023
bghgary
reviewed
Oct 2, 2023
bghgary
reviewed
Oct 2, 2023
bghgary
reviewed
Oct 2, 2023
bghgary
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The WinRT file API does not resolve symlinks when used in Win32 apps.
This change replaces the WinRT file API with calls to C++ STL fstream
functions which does resolve symlinks on Win32 builds.