Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POST requests and setting request headers. #1

Merged
merged 26 commits into from
Mar 7, 2023
Merged

Conversation

lmaskati
Copy link
Contributor

@lmaskati lmaskati commented Mar 6, 2023

This PR adds support for making POST requests and setting request headers. This PR is a draft until BabylonJS/AndroidExtensions#1 is merged, after which it needs to be tested with an updated CMake.

Copy link
Contributor

@bghgary bghgary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass. I will probably review more once the first pass is fixed.

Copy link
Contributor

@bghgary bghgary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass. I will probably review more once the first pass is fixed.

lmaskati and others added 13 commits March 7, 2023 09:53
Formatting

Co-authored-by: Gary Hsu <bghgary@users.noreply.github.com>
Co-authored-by: Gary Hsu <bghgary@users.noreply.github.com>
Co-authored-by: Gary Hsu <bghgary@users.noreply.github.com>
Co-authored-by: Gary Hsu <bghgary@users.noreply.github.com>
Co-authored-by: Gary Hsu <bghgary@users.noreply.github.com>
Co-authored-by: Gary Hsu <bghgary@users.noreply.github.com>
Co-authored-by: Gary Hsu <bghgary@users.noreply.github.com>
Co-authored-by: Gary Hsu <bghgary@users.noreply.github.com>
@lmaskati lmaskati marked this pull request as ready for review March 7, 2023 19:08
@bghgary bghgary merged commit 58b2e8f into BabylonJS:main Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants