Fix CMake 4 error#6
Merged
Merged
Conversation
CMake 4 issues an error when the cmake minimum required version is less than 3.5, and a warning when less than 3.10. This change increases the minimum CMake version to 3.10 to avoid the error and warning.
bghgary
approved these changes
May 14, 2025
bkaradzic-microsoft
added a commit
that referenced
this pull request
May 15, 2026
Continues the work in #6-#10. Removes WEBMIN guards around four opcodes/helpers that Babylon Native's shader compiler trips on: - OpSNegate (case in CompilerGLSL_emit_instruction) - OpVectorTimesMatrix (cases in emit_instruction and CompilerGLSL_emit_instruction) - OpVectorExtractDynamic (case in CompilerGLSL_emit_instruction) - to_extract_constant_composite_expression() helper (replaces INVALID_CALL stub with the real implementation already present in the same file) These were the only remaining SPIRV-Cross stubs reachable by Babylon Native's HLSL transpile path on D3D11. Net change: +35 / -20 lines.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CMake 4 issues an error when the cmake minimum required version is less than 3.5, and a warning when less than 3.10. This change increases the minimum CMake version to 3.10 to avoid the error and warning.