Skip to content

Small inclusion fix for <exception> #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SergioRZMasson merged 4 commits into from
Jun 23, 2025
Merged

Small inclusion fix for <exception> #109

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
841446e
Added <exception>
SergioRZMasson Jun 23, 2025
8eb5f33
Added check for NAPI_CPP_EXCEPTIONS
SergioRZMasson Jun 23, 2025
a5e34cb
Added check for NAPI_CPP_EXCEPTIONS
SergioRZMasson Jun 23, 2025
18a49b6
Removed unecessary files
SergioRZMasson Jun 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Core/Node-API/Include/Shared/napi/napi.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,9 @@
#endif // NAPI_HAS_THREADS
#include <string>
#include <vector>
#ifdef NAPI_CPP_EXCEPTIONS
#include <exception>
Comment thread
SergioRZMasson marked this conversation as resolved.
#endif // NAPI_CPP_EXCEPTIONS

// VS2015 RTM has bugs with constexpr, so require min of VS2015 Update 3 (known
// good version)
Expand Down Expand Up @@ -1847,10 +1850,12 @@ class Error : public ObjectReference
static Error New(napi_env env, const char* message);
static Error New(napi_env env, const std::string& message);

#ifdef NAPI_CPP_EXCEPTIONS
// [BABYLON-NATIVE-ADDITION]
static Error New(napi_env env, const std::exception& exception);
// [BABYLON-NATIVE-ADDITION]
static Error New(napi_env env, const std::exception_ptr& exception_ptr);
#endif // NAPI_CPP_EXCEPTIONS

static NAPI_NO_RETURN void Fatal(const char* location, const char* message);

Expand Down