Update Tangent W calculation #938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
W Tangent calculation was impacted by floating point rounding error and generate inverted vector randomly
Drigax
reviewed
Mar 4, 2021
| } | ||
|
|
||
| return w; | ||
| float nx = Math.Abs(normal.X) <= Tools.Epsilon ? 0 : normal.X; |
There was a problem hiding this comment.
Maybe add an override for Tools.IsAlmostEqualTo?
There was a problem hiding this comment.
Well technically this is
float nx = Tools.IsAlmostEqualTo(normal.X,Tools.Epsilon)? 0 : normal.X;
so i do not know how to name this function :-)
There was a problem hiding this comment.
Ok, no worries. I just like using helper functions for math, so they're reusable and documented via code.
A header like:
public static bool IsAlmostEqualTo(this float current, float other, float epsilon)
{
return Math.Abs(current - other) < epsilon
}
Should let us use it like
float nx = current.isAlmostEqualTo(0, Tools.Epsilon);
Just to minimize the amount of wild math we're using
Drigax
approved these changes
Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
W Tangent calculation was impacted by floating point rounding error and generate inverted vector randomly. Fix #936