Add material specific attributes #930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Babylon PBR related attribute to PhysicalMaterial, plus support for use roughness or metallic factor when map is set (Babylon or GLTF behavior)
Drigax
suggested changes
Feb 11, 2021
| isTransparencyModeFromBabylonAttributes = true; | ||
| } | ||
| gameProperty = babylonAttributesContainer.QueryProperty("babylonUseFactors"); |
There was a problem hiding this comment.
I'm a bit confused, why do we want this flag? if a map is being used for O/R/M, don't we want to export them instead of the factors?
There was a problem hiding this comment.
Max behavior is Map OR scalar, but gltf and Babylon use these factor to also multiply the values of the map. According to the GLTF 2.0 Spec "If both factors and textures are present the factor value acts as a linear multiplier for the corresponding texture values."
There was a problem hiding this comment.
Makes sense, thanks for the explanation.
Drigax
approved these changes
Feb 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Specific Babylon Full PBR related attributes to PhysicalMaterial. fix #923.
Add Babylon/GLTF attribute to force the use of roughness or metallic factor even when map is set. "Use Scalar Factor". Related to this topic
Layout the attribute to get a cleaner control