Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set missing Maya attribute from node #916

Merged
merged 2 commits into from
Jan 7, 2021

Conversation

pandaGaume
Copy link
Contributor

Maya exporter : Set the babylonBackfaceCulling & babylonUnlit material bool attribute according the node value
this fix #913

Set the babylonBackfaceCulling & babylonUnlit  material bool attribute according the node value
@Drigax Drigax merged commit 0785b04 into BabylonJS:master Jan 7, 2021
@AlexIbanez16
Copy link

I have an update concerning the babylonBackfaceCulling problem (resetting the value during the export). It's still there using the latest release of the exporter 20210107.7.

@pandaGaume
Copy link
Contributor Author

Did this happend with a particular material ? I might missed something during my repro and test.

@AlexIbanez16
Copy link

I only tried with the Stingray PBS. I'll try tomorrow with other materials (lambert, aiStandardSurface, blinn and phong) and keep you updated.

@AlexIbanez16
Copy link

Okay, so it seems that the problem persists with the Stingray PBS and the aiStandardSurface materials. Maybe it's because they have babylonStingrayPBSMaterialNode and babylonAiStandardSurfaceMaterialNode instead of a babylonStandardMaterialNode.
The lambert, phong, and blinn materials work fine.

@pandaGaume
Copy link
Contributor Author

Ok this is more clear, I migh had corrected only for the standard material and forgot a check somewhere. I will investigate this tomorrow morning my time (which is CET).

@AlexIbanez16
Copy link

Hi! I'm writing to know if you found what was causing this problem and, if not, can I be of any help?

@pandaGaume
Copy link
Contributor Author

@AlexIbanez16 Sorry for the delay, i was comitted on other works. I have to review what i published because i certainly forgot to correct some other type of material. I will try to do my best to publish a correction asap.

@pandaGaume
Copy link
Contributor Author

@AlexIbanez16 publish a fix. Might be better now. Wait for the PR to be merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maya : Backface culling reset when exporting
3 participants