Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoiding null exception when trying to optimize vertices #891

Merged
merged 4 commits into from
Nov 19, 2020
Merged

avoiding null exception when trying to optimize vertices #891

merged 4 commits into from
Nov 19, 2020

Conversation

pandaGaume
Copy link
Contributor

@pandaGaume pandaGaume commented Nov 13, 2020 •
edited
Loading

fix #861 and fix #874 and fix #822, fix #873. Update test into GlobalVertex.Equals

@pandaGaume
avoiding null exception
229e5b2
@pandaGaume
fix null material test
d65bab1
@pandaGaume
prevent all export to crash
97e5060 
introduce exception catching to prevent the whole export to crash
Drigax
Drigax approved these changes Nov 18, 2020
View reviewed changes
Copy link
Contributor

@Drigax Drigax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is a much more elegant solution.

@Drigax Drigax merged commit b37bcdc into BabylonJS:master Nov 19, 2020
@vsnappy
Copy link

vsnappy commented Nov 20, 2020

Thanks guys! Works great.

@pandaGaume
Copy link
Contributor Author

@vsnappy you're welcome, thanks for using our tools.

@pandaGaume pandaGaume deleted the OptimizeVerticeMaya branch November 20, 2020 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Drigax Drigax Drigax approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@pandaGaume @vsnappy @Drigax