Texture Formats #887
Merged
Texture Formats #887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rebase from upstream
Choice of extension for ORM, set right image format to glb buffer
make code path to glb and gltf texture write similar
Drigax
reviewed
Nov 9, 2020
| @@ -3,6 +3,11 @@ | |||
|
|
|||
| namespace BabylonExport.Entities | |||
| { | |||
| public enum TextureFormatExportPolicy | |||
| { | |||
| QUALITY, CONSERVATIV, SIZE | |||
There was a problem hiding this comment.
*CONSERVATIVE
Can we document what the intent of the export policies are? I assume Quality -> maximize image quality, CONSERVATIVE -> change as little as possible?, SIZE -> minimize image size
| @@ -498,8 +499,16 @@ private GLTFBufferView WriteImageToGltfBuffer(GLTF gltf, GLTFImage gltfImage, st | |||
| byte[] imageBytes = null; | |||
| if (imageBitmap != null) | |||
| { | |||
| ImageConverter converter = new ImageConverter(); | |||
| imageBytes = (byte[])converter.ConvertTo(imageBitmap, typeof(byte[])); | |||
| //ImageConverter converter = new ImageConverter(); | |||
There was a problem hiding this comment.
please remove commented code
| //imageBytes = (byte[])converter.ConvertTo(imageBitmap, typeof(byte[])); | ||
| using(MemoryStream m = new MemoryStream()) | ||
| { | ||
| // try our best to get extension - default will be png which is the looseless format. |
There was a problem hiding this comment.
please remove commented code
Drigax
approved these changes
Nov 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #844 Optimize format for ORM. fix size difference between GLTF and GLB. Replace raw format on GLB with corresponding Encoded format such jpg or png